Introduce model/ and repository/ structure under lib/

Models: Message, WikiPage, Game (typed structs instead of raw hashes)
Repositories: MessageBoard, OnlineUsers, WikiClient, CatalogClient
bbs.rb uses attribute access (page.title, game.play_path, …) throughout

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-04-30 09:37:57 +02:00
parent 75d1063572
commit 6856b073f6
8 changed files with 68 additions and 38 deletions

54
bbs.rb
View File

@@ -2,10 +2,10 @@
require 'bbs' require 'bbs'
require 'time' require 'time'
require_relative 'lib/online_users' require_relative 'lib/repository/online_users'
require_relative 'lib/message_board' require_relative 'lib/repository/message_board'
require_relative 'lib/wiki' require_relative 'lib/repository/wiki'
require_relative 'lib/catalog' require_relative 'lib/repository/catalog'
ONLINE = OnlineUsers.new ONLINE = OnlineUsers.new
MESSAGES = MessageBoard.new(ENV.fetch('MESSAGES_PATH', 'data/messages.dat')) MESSAGES = MessageBoard.new(ENV.fetch('MESSAGES_PATH', 'data/messages.dat'))
@@ -84,14 +84,14 @@ BBS.configure do |c|
pick from: :pages, pick from: :pages,
empty: 'No results.', empty: 'No results.',
prompt: 'Enter number to read (blank to go back)', prompt: 'Enter number to read (blank to go back)',
item: ->(p, i) { "#{C::GRAY}#{i}.#{C::RESET} #{C::BLUE}#{p['title']}#{C::RESET} #{C::GRAY}#{fmt_date(p['createdAt'])}#{C::RESET}" }, item: ->(p, i) { "#{C::GRAY}#{i}.#{C::RESET} #{C::BLUE}#{p.title}#{C::RESET} #{C::GRAY}#{fmt_date(p.created_at)}#{C::RESET}" },
hint: ->(p, i) { p['description'].to_s.strip[0...65] } do hint: ->(p, i) { p.description.to_s.strip[0...65] } do
fetch :page_body, loading: 'Loading page...' do |ctx| fetch :page_body, loading: 'Loading page...' do |ctx|
WIKI.content(ctx[:picked]['id']) WIKI.content(ctx[:picked].id)
end end
line color: :blue line color: :blue
text(style: :white) { |ctx| ctx[:picked]['title'] } text(style: :white) { |ctx| ctx[:picked].title }
text(style: :muted) { |ctx| "#{fmt_date(ctx[:picked]['createdAt'])} #{WIKI.page_url(ctx[:picked]['locale'], ctx[:picked]['path'])}" } text(style: :muted) { |ctx| "#{fmt_date(ctx[:picked].created_at)} #{WIKI.page_url(ctx[:picked].locale, ctx[:picked].path)}" }
line color: :blue line color: :blue
body { |ctx| ctx[:page_body] } body { |ctx| ctx[:page_body] }
wait_enter wait_enter
@@ -106,14 +106,14 @@ BBS.configure do |c|
pick from: :pages, pick from: :pages,
empty: 'No results.', empty: 'No results.',
prompt: 'Enter number to read (blank to go back)', prompt: 'Enter number to read (blank to go back)',
item: ->(p, i) { "#{C::GRAY}#{i}.#{C::RESET} #{C::MAGENTA}#{p['title']}#{C::RESET} #{C::GRAY}#{fmt_date(p['createdAt'])}#{C::RESET}" }, item: ->(p, i) { "#{C::GRAY}#{i}.#{C::RESET} #{C::MAGENTA}#{p.title}#{C::RESET} #{C::GRAY}#{fmt_date(p.created_at)}#{C::RESET}" },
hint: ->(p, i) { p['description'].to_s.strip[0...65] } do hint: ->(p, i) { p.description.to_s.strip[0...65] } do
fetch :page_body, loading: 'Loading page...' do |ctx| fetch :page_body, loading: 'Loading page...' do |ctx|
WIKI.content(ctx[:picked]['id']) WIKI.content(ctx[:picked].id)
end end
line color: :magenta line color: :magenta
text(style: :white) { |ctx| ctx[:picked]['title'] } text(style: :white) { |ctx| ctx[:picked].title }
text(style: :muted) { |ctx| "#{fmt_date(ctx[:picked]['createdAt'])} #{WIKI.page_url(ctx[:picked]['locale'], ctx[:picked]['path'])}" } text(style: :muted) { |ctx| "#{fmt_date(ctx[:picked].created_at)} #{WIKI.page_url(ctx[:picked].locale, ctx[:picked].path)}" }
line color: :magenta line color: :magenta
body { |ctx| ctx[:page_body] } body { |ctx| ctx[:page_body] }
wait_enter wait_enter
@@ -130,26 +130,20 @@ BBS.configure do |c|
next " #{C::RED}Could not load catalog.#{C::RESET}\r\n\r\n" unless games.any? next " #{C::RED}Could not load catalog.#{C::RESET}\r\n\r\n" unless games.any?
out = +'' out = +''
games.each_with_index do |entry, i| games.each_with_index do |game, i|
next unless entry.is_a?(Hash)
sw = entry['software'] || {}
latest = entry['latestRelease'] || {}
count = (entry['releases'] || []).length
desc = sw['desc'].to_s.strip
out << "\r\n #{C::GRAY}#{'─' * 66}#{C::RESET}\r\n" out << "\r\n #{C::GRAY}#{'─' * 66}#{C::RESET}\r\n"
out << " #{C::CYAN}#{i + 1}. #{sw['title']}#{C::RESET} " \ out << " #{C::CYAN}#{i + 1}. #{game.title}#{C::RESET} " \
"#{C::GRAY}#{sw['platform']} #{sw['author']}#{C::RESET}\r\n" "#{C::GRAY}#{game.platform} #{game.author}#{C::RESET}\r\n"
out << wrap_text(desc) unless desc.empty? out << wrap_text(game.desc) unless game.desc.empty?
badges = [] badges = []
badges << "#{C::GREEN}[▶ Play]#{C::RESET}" if latest['htmlFolderPath'].to_s != '' badges << "#{C::GREEN}[▶ Play]#{C::RESET}" unless game.play_path.empty?
badges << "#{C::YELLOW}[⬇ Download]#{C::RESET}" if latest['cartridgePath'].to_s != '' badges << "#{C::YELLOW}[⬇ Download]#{C::RESET}" unless game.download_path.empty?
badges << "#{C::BLUE}[Source]#{C::RESET}" if latest['sourcePath'].to_s != '' badges << "#{C::BLUE}[Source]#{C::RESET}" unless game.source_path.empty?
badges << "#{C::MAGENTA}[Docs]#{C::RESET}" if latest['docsFolderPath'].to_s != '' badges << "#{C::MAGENTA}[Docs]#{C::RESET}" unless game.docs_path.empty?
out << " #{badges.join(' ')}\r\n" unless badges.empty? out << " #{badges.join(' ')}\r\n" unless badges.empty?
out << " #{C::GRAY}#{CATALOG.play_url(latest['htmlFolderPath'])}#{C::RESET}\r\n" if latest['htmlFolderPath'].to_s != '' out << " #{C::GRAY}#{CATALOG.play_url(game.play_path)}#{C::RESET}\r\n" unless game.play_path.empty?
out << " #{C::GRAY}#{count} versions available#{C::RESET}\r\n" if count > 1 out << " #{C::GRAY}#{game.release_count} versions available#{C::RESET}\r\n" if game.release_count > 1
end end
out << "\r\n #{C::GRAY}#{'─' * 66}#{C::RESET}\r\n" out << "\r\n #{C::GRAY}#{'─' * 66}#{C::RESET}\r\n"

21
lib/model/game.rb Normal file
View File

@@ -0,0 +1,21 @@
# frozen_string_literal: true
class Game
attr_reader :title, :platform, :author, :desc,
:play_path, :download_path, :source_path, :docs_path,
:release_count
def initialize(entry)
sw = entry['software'] || {}
latest = entry['latestRelease'] || {}
@title = sw['title'].to_s
@platform = sw['platform'].to_s
@author = sw['author'].to_s
@desc = sw['desc'].to_s
@play_path = latest['htmlFolderPath'].to_s
@download_path = latest['cartridgePath'].to_s
@source_path = latest['sourcePath'].to_s
@docs_path = latest['docsFolderPath'].to_s
@release_count = (entry['releases'] || []).length
end
end

3
lib/model/message.rb Normal file
View File

@@ -0,0 +1,3 @@
# frozen_string_literal: true
Message = Struct.new(:timestamp, :username, :text)

3
lib/model/wiki_page.rb Normal file
View File

@@ -0,0 +1,3 @@
# frozen_string_literal: true
WikiPage = Struct.new(:id, :path, :title, :description, :created_at, :locale, keyword_init: true)

View File

@@ -3,6 +3,7 @@
require 'net/http' require 'net/http'
require 'json' require 'json'
require 'uri' require 'uri'
require_relative '../model/game'
class CatalogClient class CatalogClient
API_URL = 'https://games.teletype.hu/api/software' API_URL = 'https://games.teletype.hu/api/software'
@@ -15,7 +16,8 @@ class CatalogClient
http.open_timeout = 12 http.open_timeout = 12
http.read_timeout = 12 http.read_timeout = 12
data = JSON.parse(http.get(uri.path).body) data = JSON.parse(http.get(uri.path).body)
data.is_a?(Hash) ? (data['softwares'] || []) : data entries = data.is_a?(Hash) ? (data['softwares'] || []) : data
entries.filter_map { |e| Game.new(e) if e.is_a?(Hash) }
rescue => e rescue => e
warn "Catalog fetch error: #{e}" warn "Catalog fetch error: #{e}"
[] []

View File

@@ -3,10 +3,9 @@
require 'csv' require 'csv'
require 'time' require 'time'
require 'fileutils' require 'fileutils'
require_relative '../model/message'
class MessageBoard class MessageBoard
Message = Struct.new(:timestamp, :username, :text)
def initialize(path) def initialize(path)
@path = path @path = path
@messages = [] @messages = []
@@ -36,9 +35,7 @@ class MessageBoard
def load_csv def load_csv
return unless File.exist?(@path) return unless File.exist?(@path)
CSV.foreach(@path) do |row| CSV.foreach(@path) { |row| @messages << Message.new(*row) }
@messages << Message.new(*row)
end
rescue => e rescue => e
warn "MessageBoard load error: #{e}" warn "MessageBoard load error: #{e}"
end end

View File

@@ -3,6 +3,7 @@
require 'net/http' require 'net/http'
require 'json' require 'json'
require 'uri' require 'uri'
require_relative '../model/wiki_page'
class WikiClient class WikiClient
BASE_URL = 'https://wiki.teletype.hu' BASE_URL = 'https://wiki.teletype.hu'
@@ -17,7 +18,16 @@ class WikiClient
id path title description createdAt locale id path title description createdAt locale
}}} }}}
GQL GQL
graphql(query).dig('data', 'pages', 'list') || [] (graphql(query).dig('data', 'pages', 'list') || []).map do |p|
WikiPage.new(
id: p['id'],
path: p['path'],
title: p['title'],
description: p['description'],
created_at: p['createdAt'],
locale: p['locale']
)
end
rescue => e rescue => e
warn "Wiki list error: #{e}" warn "Wiki list error: #{e}"
[] []